Home My Page Projects gf2x
Summary Tracker Lists

[#21598] GF2X tries to build SSE2/PCLMUL tests even if --disable-hardware-specific-code

Date:
2018-02-12 13:28
Priority:
3
State:
Open
Submitted by:
Ximin Luo (infinity0)
Assigned to:
Nobody (None)
Hardware:
none
Product:
none
Operating System:
none
Component:
none
Version:
none
Severity:
none
Resolution:
none
URL:
Summary:
GF2X tries to build SSE2/PCLMUL tests even if --disable-hardware-specific-code

Detailed description
This is because in configure.ac you have

AM_CONDITIONAL([GF2X_SSE2_AVAILABLE],[test "x$gf2x_cv_cc_supports_sse2" != xno])
AM_CONDITIONAL([GF2X_PCLMUL_AVAILABLE],[test "x$gf2x_cv_cc_supports_pclmul" != xno])

but you only set those $gf2x_cv_cc_supports_* vars earlier in configure.ac if:

if test "x${enable_hardware_specific_code}" = xyes ; then
Message  ↓
Date: 2018-02-13 07:32
Sender: Emmanuel Thomé

I think I should rather make a tarball nonetheless. There's an embarrassing mistake with the shared lib versioning in 1.2.0

Date: 2018-02-12 17:37
Sender: Ximin Luo

Hi! Yes that fixes it. If there are many other changes, a tarball release would also be good.

If there are no other important changes, then no worries I've already applied this patch to Debian so another tarball release would be redundant.

Date: 2018-02-12 14:09
Sender: Emmanuel Thomé

Hi,

As far as I can tell this was fixed by commit 58beff3960c5ce252ac0b29dac355e5a3035bf81

Could you please confirm that the git version behaves according to your needs ?

Admittedly, we have not released a tarball for a long time.

E.

No Changes Have Been Made to This Item